[3c509] Re: [PATCH] EISA 3com + isa-pnp

[Andrzej Krzysztofowicz]

> > 
> > > I think that rather than trying to match the "known" 3c509
> > > device IDs, it's safer to just exclude the known 3c59x IDs.
> > 
> > I've finally the possibility to check the EISA ID of my 3c579 board.
> > It has ID=0x5093. There's no rev.no. printed on the board, just "3c579".
> > Patch, that modifies testing follows.
> > ...
> > -                       if ((device_id & 0xFF00) == 0x5900) {
> > +                       if ((device_id & 0xFFF0) != 0x5090) {
> 
> But are you *sure* that 0x590x matches all cards which
> 3c509.c supports?  I simply don't have this info, and
> I don't know where to find it.

Absolutely ? No I'm not.
I only know that this driver does not support anything else than 3c579
and my 3c579 has ID=0x5093. And I believe people from 3Com are not so stupid
to place another arbitrary ID in the card based on tha same chip. 
The last digit looks like a revision number so I mask it (similarily to
3c59x.c).
On other side, are you sure that __any__ 3Com EISA card not supported by
3c59x.c works with 3c509.c ? I'm not.

To be __absolutely__ sure one must ask 3Com technical support (and get an
answer from them)

If you worry that it does not work, maybe add a debug info about rejected
card ID's ?
Then when you get a report that some card does not work you will exactly
know what is missing...

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk