[vortex] Re: Bad PCI IDs-Names table in 3c59x.c

[Bogdan Costescu]

On Sat, 29 Mar 2003, Andrew Morton wrote:

> Nope, Donald's latest driver has
>     {"3c982 Server Tornado",{ 0x980510B7, 0xffffffff },
>      PCI_IOTYPE, CYCLONE_SIZE, FEATURE_TORNADO, },
> (Note: no HAS_NWAY either)

You missed something above that:

#define FEATURE_TORNADO  (IS_TORNADO|HAS_NWAY|HAS_V2_TX) /* 905C */

> hm, the 2.5 kernel has 
>     {"3c980C Python-T",
>      PCI_USES_IO|PCI_USES_MASTER, IS_CYCLONE|HAS_NWAY|HAS_HWCKSM, 128, },
> for 10b7/9805, which looks much more healthy.

But I would argue that this should have IS_CYCLONE replaced by IS_TORNADO. 
Not that it makes much difference though, as they are not used much in the 
code ;-)

-- 
Bogdan Costescu

IWR - Interdisziplinaeres Zentrum fuer Wissenschaftliches Rechnen
Universitaet Heidelberg, INF 368, D-69120 Heidelberg, GERMANY
Telephone: +49 6221 54 8869, Telefax: +49 6221 54 8868
E-mail: Bogdan.Costescu@IWR.Uni-Heidelberg.De