[tulip] Missing "return" in tulip private_ioctl ?
Moti Haimovsky
motih@cisco.com
Sun Apr 28 12:31:00 2002
Why isn't there a "return 0" in
case SIOCGMIIPHY: /* Get address of MII PHY in use.
*/
case SIOCDEVPRIVATE: /* for binary compat, remove in 2.5
*/
if (tp->mii_cnt)
data->phy_id = phy;
else if (tp->flags & HAS_NWAY)
data->phy_id = 32;
else if (tp->chip_id == COMET)
data->phy_id = 1;
else
return -ENODEV;
??? return 0; ???
case SIOCGMIIREG: /* Read MII PHY register. */
The case just continues, reads an arbitrary (may be illegal ?) mii register
and returns.
M.H.