[eepro100] Re: card reports no resources / RX buffers

Andrey Savochkin saw@saw.sw.com.sg
Tue, 25 Jul 2000 10:39:20 +0800


Hello,

On Mon, Jul 24, 2000 at 11:33:12AM -0700, Krawl, Roeland wrote:
> The "wait_for_cmd_done()" routine (in the eepro100 driver) falsely gives the
> impression that the
>  routine waits for command completion. After each call to
> "wait_for_cmd_done()" 
> we added an additional delay to ensure that the command has been completed
> before
> changing the contents of the System Control Block General Pointer in
> preparation for the next command.

You permanently repeat that "wait_for_cmd_done falsely gives the impression
that the routine waits for command completion".
I don't understand your point.
It waits for the chip to decode the command and be ready to accept new one.
Linux driver does the wait as any other driver (Intel, BSD).

If you think that something is done wrong, could you point it out?
I definitely don't believe that arbitrary delays inserted in different places
in the driver fix any problem.  Any delay must be properly justified by the
statements from documentation and/or examples from other existing drivers.

Best regards
					Andrey V.
					Savochkin