[3c509] Re: [PATCH] EISA 3com + isa-pnp

[Andrew Morton]

Andrzej Krzysztofowicz wrote:
> 
> Hi,
> 
> > I think that rather than trying to match the "known" 3c509
> > device IDs, it's safer to just exclude the known 3c59x IDs.
> 
> I've finally the possibility to check the EISA ID of my 3c579 board.
> It has ID=0x5093. There's no rev.no. printed on the board, just "3c579".
> Patch, that modifies testing follows.
> ...
> -                       if ((device_id & 0xFF00) == 0x5900) {
> +                       if ((device_id & 0xFFF0) != 0x5090) {

But are you *sure* that 0x590x matches all cards which
3c509.c supports?  I simply don't have this info, and
I don't know where to find it.

> ...
 -#ifdef CONFIG_ISAPNP
> +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))

err...  What's the story with CONFIG_ISAPNP_MODULE?  It isn't
defined anywhere in the config system.  In fact it isn't
defined anywhere in the entire 2.4.4-pre1 kernel.
Something is broken here.

Any idea, Alan?